search

junzis / pyModeS

Python decoder for Mode S and ADS-B signals
GNU General Public License v3.0
527 stars 151 forks source link

Remove rounding in pyModeS #147

Closed paulmadejong closed 1 year ago

paulmadejong commented 1 year ago

Provide a bit more detail for smaller roll angles. Alternatively, we could add the decimal rounding as a parameter to the roll50 function.

xoolive commented 1 year ago

@junzis I would recommend removing the rounding everywhere. It's float after all, it doesn't take more space in memory with or without rounding, people can round later if they want.

paulmadejong commented 1 year ago

@junzis I would recommend removing the rounding everywhere. It's float after all, it doesn't take more space in memory with or without rounding, people can round later if they want.

Totally agree! Or make rounding optional through function arguments (provide number of decimals or None for no rounding)?

junzis commented 1 year ago

yes, let's remove all the rounding :)