junzis / pyModeS

Python decoder for Mode S and ADS-B signals
GNU General Public License v3.0
536 stars 153 forks source link

Fix calculation of vertical rate #5

Closed astrofrog closed 8 years ago

astrofrog commented 8 years ago

The sign bit was incorrectly included in the vertical rate calculation, which resulted in all negative vertical rates being -255 or smaller

junzis commented 8 years ago

@astrofrog . thanks for pointing out. that's right. However, the bits for vertical rate is 70 to 78. so it should be: vr = util.bin2int(msgbin[69:78]). I will make a new commit to fix this along with a few other new functions.

junzis commented 8 years ago

fixed in commit: https://github.com/junzis/pyModeS/commit/2fccacd72479af28e637bfbc9a663d32a2719f3d

astrofrog commented 8 years ago

👍