search

junzis / pyModeS

Python decoder for Mode S and ADS-B signals
GNU General Public License v3.0
527 stars 151 forks source link

bds05.py: Arguments #68

Closed fre391 closed 4 years ago

fre391 commented 4 years ago

In the file bds05.py is the following description of the arguments: ''' airborne_position(msg0, msg1, t0, t1):

msg0 (string): even message (28 bytes hexadecimal string)

            # msg1 (string): odd message (28 bytes hexadecimal string)
            # t0 (int): timestamps for the even message
            # t1 (int): timestamps for the odd message

''' In the manual you are describing the following example: ''' Example: Globally unambiguous position (decoding with two messages) 8D40621D58C382D690C8AC2863A7 (newest message, which is even) 8D40621D58C386435CC412692AD6 (older message, which is odd) '''

So I would assume the params would be as follows: msg0 = 8D40621D58C382D690C8AC2863A7 (newset & even) msg1 = 8D40621D58C386435CC412692AD6 (older & odd) t0 = 10 (or similar) t1 = 20 (higher than t0) The result is not matching the value stated in the manual....

But, if I use: msg0 = 8D40621D58C382D690C8AC2863A7 msg1 = 8D40621D58C386435CC412692AD6 t0 = 20 t1 = 10

So I needed to exchange the timestamps to get the result from the example in the manual. Therefore I would assume there might be a small mistake in the argument description?

fre391 commented 4 years ago

Oh sorry, immediately after writing this topic I notice that Im wrong. Of course, the timestamp t0 needs to be higher that the t1. Well, might be a long day here....Pls, close this ticket as everything is fine....Sorry again.