jupe / puml2code

PlantUML code generator
MIT License
100 stars 19 forks source link

Improve cpp code generation #51

Closed anliec closed 4 years ago

anliec commented 4 years ago

Changes

Add the following effect during cpp code generation:

Does not change anything for other language.

Tests

The cpp test is not passing anymore, let me know how to update the template, so I can fix that. However, the result for the car.puml file are correct.

Related issues

50


Thank you for this great code base!

PS: js is not my primary language and I never used handlebars before... My code is based on what is done for ECMAScript6.

anliec commented 4 years ago

Added modification to handle template type: issue #52

jupe commented 4 years ago

Thanks for PR. There is generated test for each language which just verify generated output: https://github.com/jupe/puml2code/blob/eaa9e9909756e28e4140438fa1c1d69d5c262086/test/cli.js#L45

you should update this table: https://github.com/jupe/puml2code/blob/e2ad30766f21ffd0e6f8366deabded87efad028b/src/index.js#L123 which map generated file extension for each language.

and update&rename this file:

https://github.com/jupe/puml2code/blob/master/test/data/car.cpp.cpp

I just activated CI for PR so we can see when everything is ready for merging :)