Release cleanup - Githubissues

jupyrdf / ipyradiant

Jupyter widgets for working with RDF graphs.

BSD 3-Clause "New" or "Revised" License

5 stars 7 forks source link

Release cleanup #85

Closed zwelz3 closed 3 years ago

zwelz3 commented 3 years ago

Addressing comments left by sanbales on https://github.com/jupyrdf/ipyradiant/pull/82

Test procedure:

CI passes
Run doit locally if you want to be thorough (or check GraphExplorer example on binder).

nrbgt commented 3 years ago

If you look over at #84, it pins the versions of cytoscape, pyviz_comms, etc. that work with Lab 1... the upstreams don't pin much, so this was trial-and-error.

We should likely rock that into the README, right up front...

## JupyterLab compatibility

| `jupyterlab`    | `ipycytoscape`   | `pyviz_comms` |
| ----------------|------------------|---------------|
| `>=1,<2`        | `>=1.0.3,<1.1.0` | `>=1,<1.0.3`  |

nrbgt commented 3 years ago

or i can actually pin it in setup.cfg, which might make things smoother... but it probably already works with Lab 3 (we just haven't tested it).

zwelz3 commented 3 years ago

If you look over at #84, it pins the versions of cytoscape, pyviz_comms, etc. that work with Lab 1... the upstreams don't pin much, so this was trial-and-error.

We should likely rock that into the README, right up front...
## JupyterLab compatibility

| `jupyterlab`    | `ipycytoscape`   | `pyviz_comms` |
| ----------------|------------------|---------------|
| `>=1,<2`        | `>=1.0.3,<1.1.0` | `>=1,<1.0.3`  |

45f1ebc