🛩👩‍✈️💺 Remove almost all preflight css

jupyter-book / jupyterlab-myst

Use MyST Markdown directly in Jupyter Lab

https://jupyter-book.github.io/jupyterlab-myst/

BSD 3-Clause "New" or "Revised" License

146 stars 18 forks source link

🛩👩‍✈️💺 Remove almost all preflight css #117

Closed rowanc1 closed 1 year ago

rowanc1 commented 1 year ago

This should improve compatibility with other apps in the jupyter ecosystem. There are a few worse things in myst (e.g. icon alignment) but overall this should really cut down on any places that we are interfering with other styles (e.g. in jupyterlab-deck or holoviews).

See #105.

cc @tavin @riziles

github-actions[bot] commented 1 year ago

:point_left: Launch a Binder on branch executablebooks/jupyterlab-myst/feat/preflight

agoose77 commented 1 year ago

This nearly looks good to me! I notice a background on the text in the admonition title:

Is that unrelated to this PR? The latest PyPI release doesn't seem to show it.

rowanc1 commented 1 year ago

Yeah, I noticed that too. Ok, I am going to spend a bit of time fixing that!!

rowanc1 commented 1 year ago

Fix is here:

https://github.com/executablebooks/myst-theme/pull/40

I think that we merge this one in and fix the other things in the theme, and then can bump the versions and get another release out?