jupyter-book / jupyterlab-myst

Use MyST Markdown directly in Jupyter Lab
https://jupyter-book.github.io/jupyterlab-myst/
BSD 3-Clause "New" or "Revised" License
141 stars 18 forks source link

jupyterlab-myst extension causes issues problems with viewing the notebook in the browser #166

Closed MatusGasparik closed 1 year ago

MatusGasparik commented 1 year ago

Description

I worked on a notebook yersterday and today I noticed that large chunks of it (basically everything except for the top cell with some imports) was misteriously missing. But the notebook file is big, cat-ing it relealed that the content is there, it just want show in the browser for some reason.

I checked the browser console and saw something related to this extension:

image

So I tried deactivating the extension in the left-panel and refreshing and voilà - the notebook contenst magically appeared:

Bildschirmaufnahme 2023-06-30 um 09 52 53

Additional notes

Versions

welcome[bot] commented 1 year ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

agoose77 commented 1 year ago

Thank you for the bug report! Would you be able to share the notebook that causes this?

rowanc1 commented 1 year ago

Thanks @MatusGasparik for the bug report. @agoose77 it could potentially be this line: https://github.com/executablebooks/jupyterlab-myst/blob/dedbb1d785a02612da05fa798c7091c25b607a59/src/metadata.ts#L13

Do you know by chance when getMetadata was introduced, perhaps later than JupyterLab 4.0.0?

rowanc1 commented 1 year ago

Actually, @MatusGasparik please upgrade to v2.0.0 of the jupyterlab-myst library, the previous one was not compatible with JupyterLab 4.0!

agoose77 commented 1 year ago

@rowanc1 good eyes. I misread the version as 2.0, this makes much more sense.