Item lists rendered as task list

jupyter-book / jupyterlab-myst

Use MyST Markdown directly in Jupyter Lab

https://jupyter-book.github.io/jupyterlab-myst/

BSD 3-Clause "New" or "Revised" License

141 stars 16 forks source link

Item lists rendered as task list #220

Closed nthiery closed 6 months ago

nthiery commented 6 months ago

I just noticed that, with jupyterlab-myst 2.3.1, itemized list are (systematically?) rendered as task list.

How to reproduce

Start jupyterlab with myst >= 2.3.0 installed

E.g.: click the binder button from the documentation. Be patient until it starts. In a terminal, run pip install jupyterlab-myst==2.3.1. Reload page.

Do we have a jupyterlite under hand with the latest jupyterlab-myst available for this kind of quick tests?
Create a new cell with the following content
```
- foo
- bar
```
Render the cell.

Expected

An itemized list

Got

A task list

Note

Reverting to 2.3.0 has no effect. Reverting to 2.1.0 fixes that issue
This does not happen in the sandbox on mystmd.org.

jeremy886 commented 6 months ago

I also had the same problem and needed to downgrade to 2.1.0 to fix this.

parmentelat commented 6 months ago

same here - thanks for pointing out the working version !

in my case I also have upgraded to jlab 4.1.x; I'm pointing it out because I have seen a few extensions break with 4.1.x, so that's an angle that might be worth exploring too.

agoose77 commented 6 months ago

Thanks all! I'll look into this!

rowanc1 commented 6 months ago

Very curious @agoose77 at what the problem is, I don't think that we changed anything in this area of the code, so it could be something external we are reacting to. Note that we do have a dependency for the task-lists parsing, and if that was unpinned or upgraded, there could be something going on in there (we post process, and if the internals changed that could be it).

tavin commented 6 months ago

https://github.com/executablebooks/jupyterlab-myst/pull/223

agoose77 commented 6 months ago

Closed by #223

parmentelat commented 6 months ago

this is a very visible issue with our students setups, it would help a lot if that fix could be made shortly part of the latest pypi version... thanks in any case !