jupyter-book / jupyterlab-myst

Use MyST Markdown directly in Jupyter Lab
https://jupyter-book.github.io/jupyterlab-myst/
BSD 3-Clause "New" or "Revised" License
141 stars 16 forks source link

admonition text-wrap failure in version 2.4.2 #242

Closed zillionare closed 3 months ago

zillionare commented 3 months ago

Description

tested in version 2.4.2, admonition failed to wrap extra-length lines:

image

this works in version 2.3.1, 2.3.2 (no test beyond version 2.3.2)

image

Proposed solution

text in admonition should wrap up.

Additional notes

seems admonition text was rendered as code.

welcome[bot] commented 3 months ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

agoose77 commented 3 months ago

Hi, could you share the source for your bug report? It looks like your content is being embedded in the admonition as a code-block, so it's not being wrapped.

zillionare commented 3 months ago

the source:

\``` {note}
    plotly 中的轴类型有 linear(默认), log, date, category 和 multicategory。如果我们没有指定轴类型,plotly 会按以下顺序猜测轴类型:multicategory(只有数据本身是嵌套数组时)、date 或者 category(在我们最初的例子,会被优先判定为 date 型,从而终推断),如果还不能决定,将使用 linear。
\```

for testing, please remove backslash.

zillionare commented 3 months ago

lesson17.ipynb.zip in case you need the whole file

agoose77 commented 3 months ago

Admonition contents must not be indented unless you wish for them to be parsed as code-blocks :), i.e.

``` {note}
plotly 中的轴类型有 linear(默认), log, date, category 和 multicategory。如果我们没有指定轴类型,plotly 会按以下顺序猜测轴类型:multicategory(只有数据本身是嵌套数组时)、date 或者 category(在我们最初的例子,会被优先判定为 date 型,从而终推断),如果还不能决定,将使用 linear。

P.s., you can nested fenced blocks like admonitions by ensuring the number of backticks increases from inside-to-out, e.g.

```````markdown
````note
This contains a figure!
```figure foo.png