jupyter-book / myst-theme

Packages for creating MyST websites themes using React and Remix
https://jupyter-book.github.io/myst-theme/?path=/docs/components-introduction--docs
MIT License
12 stars 12 forks source link

Serve theme documentation from this repository and add PR previews #391

Open choldgraf opened 3 months ago

choldgraf commented 3 months ago

Currently, we store the documentation for our bundled myst themes in the mystmd repository. The documentation in this repository is a demo site of components for references.

By having the documentation for the theme in a separate repository, we have a few downsides:

I propose that we do the following things:

agoose77 commented 1 month ago

I think you've identified some good points of improvement for our two-repo ecosystem. At the heart of this issue is the fact that we have three kinds of documentation:

The problems we need to solve are:

We're currently taking the approach that most users should just go to mystmd.org for documentation in this ecosystem -- a departure from the JB1 approach which has docs split around the ecosystem. That introduces two problems; fragmentation and repetition of information and fragmentation of resources (i.e. multiple sites in your search engine). However, this does mean that the coupling between components in terms of where the code lives is not so obvious.

So, my summary of the problems we need to solve in this space is:

  1. We should not bless our own web themes too much; we want it to be obvious that developers can add their own and users can look for them.
  2. We should have theme component documentation (Storybook)
  3. We should make it possible to preview changes to our theme components
  4. We should have documentation on our pre-designed themes
  5. We should make it possible to preview changes to our pre-designed themes

It might not be super easy to solve all of these; there may be some trade-offs. But, I'll take a stab at something and see where we end up.

choldgraf commented 1 month ago

Just noting that I generally agree with all of the above, and: I suggest that we take an MVP approach here. For example if moving the docs over here would be complicated, it could be helpful to at least run a docs preview in our PRs of the mystmd.org/guide docs that use the latest assets in this repository so that we can see things. Then we could decide/deal with moving documentation later.

agoose77 commented 1 month ago

@choldgraf took the words right out of my mouth! I think this is actually the right step; figuring out the higher level changes will probably need to wait until the rest of the team are present.