search

jupyter-book / mystmd

Command line tools for working with MyST Markdown.
https://mystmd.org/guide
MIT License
208 stars 61 forks source link

␡ Enable strikethrough as markdownit extension #1427

Closed sglyon closed 2 months ago

sglyon commented 2 months ago

Ends up parsing out to a delete node and uses the rendering logic for the delete directive

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: fcbcd94dc626633afedc5fe2ec785dda8e796ec6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages | Name | Type | | --------------- | ----- | | myst-parser | Patch | | myst-roles | Patch | | myst-directives | Patch | | myst-to-html | Patch | | myst-transforms | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

sglyon commented 2 months ago

Thanks for adding those tasty-fireants!

Is this one good to go?

sglyon commented 2 months ago

Hi @rowanc1 is this ready to merge?

rowanc1 commented 2 months ago

Added a test - thanks for the nudge.

Will get this in when it goes green!

rowanc1 commented 2 months ago

Thanks @sglyon for your help!