jupyter-book / thebe

Turn static HTML pages into live documents with Jupyter kernels.
https://thebe.readthedocs.io
BSD 3-Clause "New" or "Revised" License
392 stars 68 forks source link

Can't change theme to cobalt #460

Closed FasihZafar closed 1 year ago

FasihZafar commented 3 years ago

Describe the problem

I have followed the contribution guide and managed to get there up and running on local host. After which I tried switching theme value to cobalt inside the script tag:

But nothing changes.

Link to your repository or website

No response

Steps to reproduce

  1. follow the instructions from here https://thebe.readthedocs.io/en/latest/contribute.html#set-up-a-development-environment
  2. add the them key value pair in the codeMirrorConfig dictionary

The version of Python you're using

No response

Your operating system

No response

Versions of your packages

No response

Additional context

No response

welcome[bot] commented 3 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

stevejpurves commented 3 years ago

Hi @FasihZafar

Thanks for reporting. So yes it looks like the codemirror theme is not being applied at all, and I don't think there is code in place to actually implement it!

In order to apply codemirror theme, it is necessary to load the appropriate css file which thebe is not doing for you. However, even if I manually add the cobalt.css to my page, and set the option it still does not work. Perhaps we need configure codemirror differently in the version we on which is 5.61.1.

Definitely an issue though.

stevejpurves commented 1 year ago

this is now possible see https://executablebooks.github.io/thebe/ where darcula is loaded