search

jupyter-book / thebe

Turn static HTML pages into live documents with Jupyter kernels.
https://thebe.readthedocs.io
BSD 3-Clause "New" or "Revised" License
395 stars 68 forks source link

Transition to ESM modules + bundles #705

Open stevejpurves opened 11 months ago

stevejpurves commented 11 months ago

Currently the thebe subpackages are build as a mix of cjs, esm and browser bundles. Testing is using a mix of vitest and jest, where jest is now problematic and we cannot complete a buuldl after recent dependency updates.

Proposal - transition fully to esm modules, producing ESM builds and bundles and dropping cjs builds. Adopt vitest for all testing and extend thebe's testing by using cypress or puppeteer.

It's thought that fully embracing ESM will help avoid numerous build problems we are having as the dependencies we use are transitioning.

stevejpurves commented 11 months ago

Ava yes we are! 🙌 ᐧ

On Fri, Nov 24, 2023 at 10:03 PM Ava Givone @.***> wrote:

@stevejpurves https://github.com/stevejpurves I am working with a group from my college to contribute to an open source project for an assignment for our software engineering class, and we are interested in tackling this issue. Are you still inquiring for help on this issue?

— Reply to this email directly, view it on GitHub https://github.com/executablebooks/thebe/issues/705#issuecomment-1826107562, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALHY3VYM6D7IFKNEKDLFULYGEKTPAVCNFSM6AAAAAA7TJL2W2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGEYDONJWGI . You are receiving this because you were mentioned.Message ID: @.***>