search

jupyter-incubator / contentmanagement

Jupyter Content Management Extensions
Other
78 stars 26 forks source link

Fix #56: Notebook 5.0 compat #57

Closed parente closed 7 years ago

parente commented 7 years ago

Fixes the install process under notebook 5.0.

Removes the bundler ability completely in favor of the implementation in notebook 5.0. Doing this forces jupyter/dashboards_bundlers (and other clients of the bundler API) to require notebook>=5.0 or to rely on jupyter_cms<0.7 once this gets released.

parente commented 7 years ago

@jtyberg would you mind taking a quick look see at the final result here to make sure it's not totally off in the weeds?

jtyberg commented 7 years ago

I tested on notebook 4.4.1 without issue.

Bye-bye bundlers.

parente commented 7 years ago

Thanks for the review, @jtyberg