Missing comma on sparkmagic/hdijupyterutils/setup.py

jupyter-incubator / sparkmagic

Jupyter magics and kernels for working with remote Spark clusters

Other

1.33k stars 447 forks source link

Closed GaspardBT closed 3 years ago

GaspardBT commented 3 years ago

Hi, I hope I'm not flooding or x-posting Following this documentation shouldn't the following line contains a comma. https://github.com/jupyter-incubator/sparkmagic/blob/fdbd44fad258c8bd6e889d274fa14ed1b7726188/hdijupyterutils/setup.py#L64 Is this expected or a known issue?

devstein commented 3 years ago

Hi @Pokiharena thanks for making an issue! This is not expected nor a known issue. Would you be open to making a PR to fix it?

GaspardBT commented 3 years ago

Hi created a draft request but I'm not sure with the next step. Could take a look?

devstein commented 3 years ago

@Pokiharena Thank you! I left a comment, but once you address mark the PR as "Ready for Review" and I will approve and merge