search

jupyter-lsp / jupyterlab-lsp

Coding assistance for JupyterLab (code navigation + hover suggestions + linters + autocompletion + rename) using Language Server Protocol
https://jupyterlab-lsp.readthedocs.io
BSD 3-Clause "New" or "Revised" License
1.79k stars 145 forks source link

Status popup is cropped with Notebook 7 #690

Open jtpio opened 2 years ago

jtpio commented 2 years ago

Description

Testing with this gist on Binder and the latest RetroLab 0.3.9: https://gist.github.com/jtpio/655b5ab8c6bf28e44aaf79f8313b68f0

The status popup appears to be cropped and is hiding content (not scrollable):

image

Reproduce

From this gist: https://gist.github.com/jtpio/655b5ab8c6bf28e44aaf79f8313b68f0

On Binder with RetroLab: https://mybinder.org/v2/gist/jtpio/655b5ab8c6bf28e44aaf79f8313b68f0/master?urlpath=/retro

Expected behavior

We could either add an overflow: auto to enable scrolling.

image

Or make the popup take more space on the bottom.

image

Context

krassowski commented 2 years ago

I like both idea, but it would be probably more usable when placed on the bottom.

The geometry of the popup is hardcoded upstream as privilege: 'forceAbove' (https://github.com/jupyterlab/jupyterlab/blob/d48e0c04efb786561137fb20773fc15788507f0a/packages/statusbar/src/components/hover.tsx#L144-L194), we would need to extend the Popup.IOptions. I think that this is the ultimate solution, but for now making it scrollable would be a good step forward.