search

jupyter-naas / awesome-notebooks

A powerful data & AI notebook templates catalog: prompts, plugins, models, workflow automation, analytics, code snippets - following the IMO framework to be searchable and reusable in any context.
https://naas.ai/search
BSD 3-Clause "New" or "Revised" License
2.65k stars 446 forks source link

feat: Naas Storage API notebook #2537

Closed l-loic closed 2 months ago

l-loic commented 3 months ago

Fixes

This PR resolves #2523

What does this PR do?

Naas Storage API Notebook

FlorentLvr commented 3 months ago

@l-loic, i checked your notebook and it does respect our framework. Could you please adapt it? 🙏 TY https://github.com/jupyter-naas/awesome-notebooks?tab=readme-ov-file#how-is-organized-a-template

Image

FlorentLvr commented 3 months ago

@l-loic, it's hard to review as the notebook is huge and has information about differents functions. Could you please create one notebook by function like I did for asset:

gitguardian[bot] commented 2 months ago

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [11541006](https://dashboard.gitguardian.com/workspace/170551/incidents/11541006?occurrence=154958331) | Triggered | Generic Password | 70e20004db4bf8fc9a1533c3dc7b05444f698a4f | Naas API/Naas_API_Update_Asset.ipynb | [View secret](https://github.com/jupyter-naas/awesome-notebooks/commit/70e20004db4bf8fc9a1533c3dc7b05444f698a4f#diff-58384d1294e66bf0bc7548e5edc5c166f01de3010f2d0fbc5cf9631daed8db8dR253) | | [11541006](https://dashboard.gitguardian.com/workspace/170551/incidents/11541006?occurrence=154958332) | Triggered | Generic Password | 70e20004db4bf8fc9a1533c3dc7b05444f698a4f | Naas API/Naas_API_Get_Asset.ipynb | [View secret](https://github.com/jupyter-naas/awesome-notebooks/commit/70e20004db4bf8fc9a1533c3dc7b05444f698a4f#diff-7792157da8c0ef0ba735af8e9b8d0f79be0547e5c0254ea6992c03e3b7da9b8fR244) | | [3347580](https://dashboard.gitguardian.com/workspace/170551/incidents/3347580?occurrence=154958330) | Triggered | GitHub Access Token | 70e20004db4bf8fc9a1533c3dc7b05444f698a4f | GitHub/GitHub_Get_commits_ranking_from_repository.ipynb | [View secret](https://github.com/jupyter-naas/awesome-notebooks/commit/70e20004db4bf8fc9a1533c3dc7b05444f698a4f#diff-19d43ffdcf1cb2f75a558259f7cfc3eed25577effd5690eb7a64e81cfacc9da9L130) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

l-loic commented 2 months ago

@FlorentLvr hi, you may review

FlorentLvr commented 2 months ago

@l-loic , as we discussed, I test your notebooks and it failed on:

OK: