search

jupyter-naas / naas

Low-code Python library to safely use notebooks in production: schedule workflows, generate assets, trigger webhooks, send notifications, build pipelines, manage secrets (Cloud-only)
https://app.naas.ai/
GNU Affero General Public License v3.0
286 stars 25 forks source link

fix(downloader): Update redirect url to open downloaded file #132

Closed Dr0p42 closed 3 years ago

Dr0p42 commented 3 years ago

This pull request is here to fix the "Open in naas" logic.

There was an issue where the file was being downloaded but the user was not redirected to a jupyter workspace where the file is effectively opened.

jravenel commented 3 years ago

I saw that but though it was normal behavior, thanks 🙏 also the dl_ prefix is not necessary, I guess it's another pr

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication