Naas run - Do not add naas.run() as webhook task in naas manager

jupyter-naas / naas

Low-code Python library to safely use notebooks in production: schedule workflows, generate assets, trigger webhooks, send notifications, build pipelines, manage secrets (Cloud-only)

https://app.naas.ai/

GNU Affero General Public License v3.0

282 stars 25 forks source link

Naas run - Do not add naas.run() as webhook task in naas manager #201

Closed FlorentLvr closed 2 years ago

FlorentLvr commented 3 years ago

Behaviour expected :

Add notebook in task manager with a different name (_run.ipynb)
Run notebook (with webhook feature)
Get output when failed
Delete webhook in task manager

jravenel commented 3 years ago

@Dr0p42 @FlorentLvr as discussed I removed @tparente-ui from this task: too deep.

jravenel commented 3 years ago

Looking at the code, it seems an enhancement to me.

Dr0p42 commented 3 years ago

Ok I took a look at this issue, it seems indeed that when there is an error occurring when doing a naas.run(), the task is not removed.

history

We can see that on error the task is kept.

Used notebook:

jravenel commented 3 years ago

After discussion, there is no straightforward solution to that. At one point we will need to refactor this feature and therefore, we are putting it back to the Backlog.

jravenel commented 2 years ago

Fixed.