Jupyterlab1.0

[juliusvonkohout]

Update to jupyterlab 1.0.x JupyterLab now has a File > Logout menu entry when running with JupyterHub.

https://github.com/jupyterlab/jupyterlab/blob/master/docs/source/getting_started/changelog.rst#jupyterhub-integration says "We now include the JupyterHub extension in core JupyterLab, so you no longer need to install @jupyterlab/hub-extension. (#6451, #6428) "

superseedes #12 @GrahamDumpleton

[juliusvonkohout]

@GrahamDumpleton are you still maintaining this repository? Otherwise we would fork it.

[GrahamDumpleton]

Still maintaining it, just been super super busy on other stuff the last month. I also have to be very careful on upgrade path to newer packages especially around JupyterHub moving to 1.0 as they remove various options previously marked as obsolete for separate JupyterHub repository, so have a bunch of example repos that use it that need to update at the same time, and warn some users. So is lot of changes that need to be done outside of this repo as well, so need to ensure I have enough time to do it all at once. Things should get better time wise after this coming week.

[juliusvonkohout]

We are also using your jupyterhub repository with tag 3.0.7.

[juliusvonkohout]

Do you have any eta when you will have time? Also jupyterhub could be upgraded to 1.0.

[GrahamDumpleton]

I am going to break this into separate sets of changes. First will be to drop Python 2.7 support.

• https://github.com/jupyter-on-openshift/jupyter-notebooks/issues/14

In then looking at updating package versions, need to understand why you have remove version pinning for various repositories. That is, why version has been dropped from notebook and the various lab extensions?

[GrahamDumpleton]

BTW, I have created a project board to cover all the repos so you can see greater view of what needs to be done. I will add more issues against various repos as work out implications of these changes and what else needs to change. The project board can be seen at:

https://github.com/orgs/jupyter-on-openshift/projects/2

[juliusvonkohout]

i have pinned everything now. Would you mind noting in the commit message or somewhere else, that that the commits came from me? Since you split it up and merge small parts the authoring is lost.

[GrahamDumpleton]

Updating to JupyterHub 1.0.0 is going to cause problems with authentication. See:

• https://github.com/jupyter-on-openshift/jupyterhub-quickstart/issues/20#issuecomment-527111252

[juliusvonkohout]

Please note that jupyterlab 1.1.1 works with jupyterhub 0.9.4. So this change can be handled on its own. But of course, at some point in the future we should upgrade.

[GrahamDumpleton]

I will be going to jupyterhub 1.0. I have been working out all the kinks in using it and understanding how it is different with our Homeroom workshop environment which also uses JupyterHub. I will be extending the jupyterhub-quickstart to allow a jupyterhub_config.sh file to set things which now must be done as environment variables. Once that is done I need to update the various examples based on it. Then I can move it all to jupyterhub 1.0.

[juliusvonkohout]

So should i change the pull request or will you merge the remaining parts manually?

[GrahamDumpleton]

The state of things is I have added support for a jupyterhub_config.sh file to jupyterhub-quickstart to support the changes in JupyterHub 1.0. I updated poc-hub-openshift-auth to use jupyterhub_config.sh to set up auth and I think I switched that poc to use pre-built images instead of building from scratch. I haven't closed the issues for the poc changes though, so not sure if there was something still had to do. I was then side tracked as was off at RHTE and also been busy creating new 3 hour workshop for conference on next week. I still haven't update poc for keycloak auth same as OpenShift auth yet. Getting at least the OpenShift auth one switched was necessary before I could put in JupyterHub 1.0 otherwise it would break immediately.

Anyway, it is going to probably be easier for me to make the remaining changes as I will do them in lock step with the jupyterhub-quickstart changes to add JupyterHub 1.0.

So sorry for the delay, just keep getting higher priority things have to do. Once I get this 3 hour workshop finished, hopefully in next couple of days, I will have a bit of clear time again, but only a bit as need to update another workshop for OCP 4.2 next which only got couple of weeks to do. :-)

[juliusvonkohout]

Do you have some spare time now?

[GrahamDumpleton]

I have been working on Jupyter stuff and training scenarios for these repos for the past week. I will be updating to latest packages today or tomorrow since I need to align with JupyterHub 1.X to get the newer way of handling auth to avoid examples needing to be change later.

[juliusvonkohout]

Ah thank you. I have two qustions:

1. Is there a reason that you have tornado<6.0.0 in requirements.txt? tornado6 is fine with jupyterlab. i suggest to just remove it

2. why is supervisor not in the requirements.txt, but instead installed in the assemble scripts?

[GrahamDumpleton]

Originally it was still tornado < 6.0.0 because it had to be to still support Python 3.5. But then I screwed up anyway and bumped some other package versions which wouldn't even install under Python 3.5 and didn't realise the builds were breaking for it. So now it uses older Tornado with Python 3.5 and newer Tornado with Python 3.6.

The supervisor and mod_wsgi packages were installed separately because saw them as part of the underlying bits supporting the running of the container and not part of what was required for Jupyter notebooks to work, so was avoiding the confusion of mixing them. I might revisit that at some point.

[juliusvonkohout]

Thank you very much. I will close this pull request then.