search

jupyter-on-openshift / jupyter-notebooks

OpenShift compatible S2I builder for basic notebook images.
Apache License 2.0
54 stars 111 forks source link

Fix JupyterLab Build by updating default python 3.5. to 3.6 #3

Closed juliusvonkohout closed 5 years ago

juliusvonkohout commented 5 years ago

Jupyterlab 0.35.4 needs a newer nodejs which is not in python:3.5 referenced in images.json. Please update to python:3.6 by merging https://github.com/juliusvonkohout/jupyter-notebooks/commit/b07899cf3eb5c337564030a47af06120f462cbc8

GrahamDumpleton commented 5 years ago

Both the Python 3.5 and 3.6 S2I images should share a common base image from which node.js is used. AFAIK they both have node.js 10.0. What version of node.js is required?

juliusvonkohout commented 5 years ago

Well you are partly right. I used an outdated rhel python:3.5. The current one has 

(app-root)sh-4.2$ node --version                                                
v8.11.4

which is sufficient.

It would still be very kind to update the default version to 3.6. Nevertheless the second issue https://github.com/jupyter-on-openshift/jupyter-notebooks/issues/2 is way more important.

GrahamDumpleton commented 5 years ago

My mistake, node.js 8.X is indeed the latest used in Python S2I images.

GrahamDumpleton commented 5 years ago

Should hopefully be addressed in latest 2.0.0 tag.

GrahamDumpleton commented 5 years ago

And now that have switched to Python 3.6, it is no longer possible to deploy using S2I the Jake Vanderplus notebooks, as they require Python 3.5. :-(