search

jupyter-on-openshift / jupyterhub-quickstart

OpenShift compatible version of the JupyterHub application.
Apache License 2.0
102 stars 107 forks source link

Lab always enabled #13

Closed guimou closed 6 years ago

guimou commented 6 years ago

Hi! I have a config map with some launch items enabling JupyterLab, some not:

    c.ProfilesSpawner.profiles = [
    (
        "Minimal Notebook w/ JupyterLab",
        's2i-minimal-notebook',
        'kubespawner.KubeSpawner',
        dict(singleuser_image_spec='s2i-minimal-notebook:3.5',environment=dict(JUPYTER_ENABLE_LAB='true'))
    ),
    (
        "Minimal Notebook",
        's2i-minimal-notebook',
        'kubespawner.KubeSpawner',
        dict(singleuser_image_spec='s2i-minimal-notebook:3.5')
    ),...

However all my images are launched with the JupterLab interface. And of course I don't have c.KubeSpawner.environment = dict(JUPYTER_ENABLE_LAB='true') in the configuration.

I'm pretty sure this did not behave like this in my previous installations. What do I miss?

GrahamDumpleton commented 6 years ago

How are you installing it?

If using the poc-hub-keycloak-auth I have Lab enabled by default. All other installation methods have it off as far as I know.

If using that demo example, set the template parameter JUPYTERLAB_ENABLED=false when instantiating the template. You can turn it off by changing the environment variable JUPYTERHUB_ENABLE_LAB in the JupyterHub deployment. The lab support will still be in the image. If wanting to not have lab support built in, then set JUPYTER_INSTALL_LAB to false in the notebook build configuration.

BTW, upcoming JupyterHub will not need ProfilesSpawner as it has a bundled in mechanism for profiles.

guimou commented 6 years ago

No, it's the templates and images from jupyterhub-quickstart, following the instructions. Which was working well in my previous installations... If nothing has changed recently I'll try to redeploy from scratch. I did not try the new poc with keycloak, as everything is bundled together and we already have a keycloak instance.

On Wed, Jul 18, 2018, 18:25 Graham Dumpleton, notifications@github.com wrote:

How are you installing it?

If using the poc-hub-keycloak-auth I have Lab enabled by default. All other installation methods have it off as far as I know.

If using that demo example, set the template parameter JUPYTERLAB_ENABLED=false when instantiating the template. You can turn it off by changing the environment variable JUPYTERHUB_ENABLE_LAB in the JupyterHub deployment. The lab support will still be in the image. If wanting to not have lab support built in, then set JUPYTER_INSTALL_LAB to false in the notebook build configuration.

BTW, upcoming JupyterHub will not need ProfilesSpawner as it has a bundled in mechanism for profiles.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jupyter-on-openshift/jupyterhub-quickstart/issues/13#issuecomment-406093418, or mute the thread https://github.com/notifications/unsubscribe-auth/ADwuYnvq7g18Sfrk55nX3EHskc6LfXhUks5uH7XJgaJpZM4VVAdC .

GrahamDumpleton commented 6 years ago

I changed the check for installation of Lab support so took precise value a while back, but I don't think I stuffed it up.

The check to then see if it is used or not is:

Only other way I think Lab support can be turned on when running, is if:

is run as the startup command for the notebook from JupyterHub.

I will do a build and install later when have a chance, but pretty sure when did it couple days ago after I starting tagging versions it was fine.

GrahamDumpleton commented 6 years ago

Damn, then he sees that:

should be looking for truth value and not non zero. So that will be an issue.

GrahamDumpleton commented 6 years ago

IOW, set JUPYTER_ENABLE_LAB environment variable to empty value, or remove it, if currently being set. It isn't set by templates, so maybe you set it at some point to see if worked not realising that any non empty value enabled it. When I added more precise check for build, missed it for running.

GrahamDumpleton commented 6 years ago

Try rebuilding the minimal notebook image again. I have made the change so is more specific about what it accepts for enabling JupyterLab. That was if had set to some notionally false before (rather than empty string or deleting variable), then should not enable it.

guimou commented 6 years ago

I found the problem... Unfortunately it's me! I'm so ashamed I don't want to tell, but for the sake of properly closing issues I have no choice. I simply duplicated items in the config map to create the w/ Lab entries, changed the title, added the environment variable, but did not rename the entry name... :-( So whatever came second in the list just erased the previous configuration that had the same name...