search

jupyter-on-openshift / jupyterhub-quickstart

OpenShift compatible version of the JupyterHub application.
Apache License 2.0
101 stars 107 forks source link

Parametrize OAuth settings and set them in the Juptyerhub environment… #28

Closed odontomachus closed 4 years ago

odontomachus commented 4 years ago

The OAuth client secret is assumed to come from a secret. This should be documented.

This allows the template to work with Juptyerhub 1.0 with OAuthenticator being loaded before the jupyterhub config file. This also simplifies the Jupyterhub config file.

This could be a solution for #26 rather than adding a configuration file to set the environment before starting Jupyterhub.

GrahamDumpleton commented 4 years ago

The latest versions of jupyterhub-quickstart support providing a jupyterhub_config.sh which can set environment variables for the JupyterHub process. This is the mechanism currently being used to allow you to set additional environment variables for OAuth.

As example see:

There is also a template parameter JUPYTERHUB_ENVVARS for supplying this when deploying.

I would rather stick with this rather than introduce a whole lot more template parameters which are specific to one deployment case.

Can you try instead providing the configuration via JUPYTERHUB_ENVVARS template parameter instead?

odontomachus commented 4 years ago

This actually works even better. Thanks.