Closed kevin-bates closed 2 years ago
probably should add helm lint to the make script and use helm package instead of tar
:
$ helm lint ./enterprise_gateway/./etc/kubernetes/helm/enterprise-gateway
--
2 | ==> Linting ./enterprise_gateway/./etc/kubernetes/helm/enterprise-gateway
3 |
4 | 1 chart(s) linted, 0 chart(s) failed
5 | $ helm package --version=0.4.104 ./enterprise_gateway/./etc/kubernetes/helm/enterprise-gateway
6 | Successfully packaged chart and saved it to: /src/git.target.com/Kubernetes/external-helm-chart/enterprise-gateway-0.4.104.tgz
I see. So helm package
is the preferred way to distribute the set of "chart files"?
Since version
(and appVersion
) are specified in the Chart.yaml
, I'm assuming they're not required on the command-line, correct?
Closing via #1073.
Description
When using the helm chart from the primary branch (i.e., during development), the chart will not pass the
helm lint
check due to its semantic versioning check - as reported here: https://github.com/jupyter-server/enterprise_gateway/pull/1073#discussion_r849543939.Since
appVersion
doesn't require semantic version syntax and is meant to represent the "hosted" application's version, we should move the value ofversion
toappVersion
and makeversion
a function of whenChart.yaml
(or associated files) are updated.This will require changes to the release script as well.
Reproduce
helm lint enterprise-gateway
Expected behavior
helm lint
should not produce errors.