search

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
620 stars 223 forks source link

[pre-commit.ci] pre-commit autoupdate #1141

Closed pre-commit-ci[bot] closed 2 years ago

pre-commit-ci[bot] commented 2 years ago

updates:

kevin-bates commented 2 years ago

This is failing due to https://github.com/globality-corp/flake8-logging-format/issues/35. A PR has been merged so we're now waiting for a release. Since our default builds fail during their lint step due to this issue, I think it's best to wait to merge this PR so real build failures are still detected. Should this take more than a day or two, then we may need to look at adjusting the pre-commit rules so that this issue is avoided - if that's even possible.

Actually, I'm going to place this PR into DRAFT for the time being.

kevin-bates commented 2 years ago

After removing flake8-logging-format, as was done in other repositories, a new flake8 version 5 incompatibility surfaced with flake8-bugbear, which requires version >= 22.6.22. I've applied these two changes and the build appears to be moving forward. As a result, I'm taking this PR out of DRAFT. See https://github.com/jupyter-server/jupyter_server/pull/941 for another reference.