search

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
620 stars 223 forks source link

Remove cap for jupyter-server #1165

Closed kevin-bates closed 2 years ago

kevin-bates commented 2 years ago

The Jupyter Server issue that was previously causing CI issues has been resolved in its 1.19.1. This PR removes that previously imposed cap. It does not, however, increase the floor of the dependency to >=1.19.1. I didn't feel that was warranted, so should someone have installed 1.19.0 in its brief 4-day lifetime, they may run into an issue that will log something like the following...

[D 2022-09-27 04:19:12.195 EnterpriseGatewayApp] Nudge: not nudging busy kernel 39ce47c4-64c4-4b0e-a2cf-4f998d1b8880
[E 220927 04:19:12 web:1793] Uncaught exception GET /api/kernels/39ce47c4-64c4-4b0e-a2cf-4f998d1b8880/channels (172.17.0.1)
    HTTPServerRequest(protocol='http', host='localhost:8888', method='GET', uri='/api/kernels/39ce47c4-64c4-4b0e-a2cf-4f998d1b8880/channels', version='HTTP/1.1', remote_ip='172.17.0.1')
    Traceback (most recent call last):
      File "/opt/conda/lib/python3.7/site-packages/tornado/websocket.py", line 956, in _accept_connection
        await open_result
    TypeError: object Future can't be used in 'await' expression
kevin-bates commented 2 years ago

Since this is just reverting a previous change (and I've confirmed the tests pass in my fork), I'm proceeding with its merge.