jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
615 stars 221 forks source link

Rename CRD kill method and incorporate terminate_custom_resources #1175

Closed kiersten-stokes closed 1 year ago

kiersten-stokes commented 1 year ago

Fixes #1167

This PR includes the changes suggested in https://github.com/jupyter-server/enterprise_gateway/issues/1167#issuecomment-1267584529

Prior to these changes, the spark operator pods lingered without being terminated on kernel change despite the pod logs indicating that the shutdown signal as received.

[I 2022-10-19 16:01:07,027.027 launch_ipykernel] server_listener got request: {'signum': 2}
[I 2022-10-19 16:01:07,028.028 launch_ipykernel] server_listener got request: {'shutdown': 1}

Now, pods are deleted on kernel change as expected. @vivekbhide also confirmed as such in https://github.com/jupyter-server/enterprise_gateway/issues/1167#issuecomment-1269282302