search

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
615 stars 221 forks source link

Release script produces invalid helm chart version strings #1177

Closed kevin-bates closed 1 year ago

kevin-bates commented 1 year ago

The release script is not processing the replacement of the current value with the new value correctly resulting in the previous suffix remaining. For example, the current version: string is 3.1.0-dev0-rc0-dev0-b0 - which started as 3.0.0-b0. This is because it's not recognizing the hyphen in its pattern match, resulting the in the previous suffix remaining for each update (release and back to dev version).

We should also take this opportunity to name the helm chart tar file using the same pattern as the kernelspecs. For example, these tar files are considered assets for each release...

enterprise-gateway-3.0.0-rc0.tgz
jupyter_enterprise_gateway_kernel_image_files-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernelspecs-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernelspecs_conductor-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernelspecs_docker-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernelspecs_kubernetes-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernelspecs_yarn-3.0.0rc0.tar.gz

The first file listed is the helm chart distribution. We should name this file something like jupyter_enterprise_gateway_helm-3.0.0-rc0.tgz resulting in a listing like...

jupyter_enterprise_gateway_helm-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernel_image_files-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernelspecs-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernelspecs_conductor-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernelspecs_docker-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernelspecs_kubernetes-3.0.0rc0.tar.gz
jupyter_enterprise_gateway_kernelspecs_yarn-3.0.0rc0.tar.gz

Note that both the prefix and version suffix change in this case.

@darkstarmv - so long as we move the output file produced by helm package ... to the "normalized" name my tests show this rename should not impact running helm install enterprise-gateway jupyter_enterprise_gateway_helm-3.0.0rc0.tar.gz, but I'm hoping to get your opinion/confirmation.