jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
615 stars 221 forks source link

Fix helm version handling and package naming #1178

Closed kevin-bates closed 1 year ago

kevin-bates commented 1 year ago

The helm version (whose format differs from that of the release version format) was not being handled correctly via the release.sh script. This pull request addresses that by recognizing hyphens.

In addition, the asset produced by make helm-chart (actually via the helm package) command, does not follow the same naming convention as that of the other assets we include. This PR renames the file to that of the other assets (and actually closer to what we originally documented - whose suffix is updated in this PR as well).

Fixes: #1177