search

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
615 stars 221 forks source link

Missing await in KubernetesProcessProxy #1183

Closed kevin-bates closed 1 year ago

kevin-bates commented 1 year ago

While working on the Remote Provisioners, I found an issue in KubernetesProcessProxy in which its terminate_container_resources() method is not calling await on get_container_status(). We'll need to add the await and create a patch release.

kevin-bates commented 1 year ago

:smile: It turns out this is a false alarm. The Remote Provisioners mark this method as async, while EG doesn't. As a result, this issue can be closed (invalid).