search

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
620 stars 223 forks source link

Support 'cull connected kernels' as a config in helm and create a way to dynamically pass other environments variables to helm deployment #1231

Closed luong-komorebi closed 1 year ago

luong-komorebi commented 1 year ago

To minimise the work for helm users in catching up with all the environment variables that EG might create and use, I create a extraEnv field, which will help the users create envs and values, even before maintainers port some of them as a config in helm

Speaking of configs, one major thing that enterprise gateway demo and start script is using that is yet to be configurable via helm is EG_CULL_CONNECTED. This PR also exposes that as a config, since we already have EG_CULL_IDLE_TIMEOUT in helm (although to be fair, one could use the extraEnv to achieve the same goal)

kevin-bates commented 1 year ago

@luong-komorebi - would you mind merging with main so we can ensure the tests are clean? I think the failures are due to not having the recently merged change in #1230.