jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
615 stars 221 forks source link

Fix the flow of kernel-class-name option in bootstrap script #1260

Closed manoj-jeswani closed 1 year ago

manoj-jeswani commented 1 year ago

This pull request fixes an issue with the value and the assignment syntax being used to populate the kernel_class_option variable inside the bootstrap-kernel.sh script. This will resolve the flow of --kernel-class-name option from the bootstrap script to python kernel launcher in the kernel containers.

Please find more details on the issue here.

Resolves #1184

welcome[bot] commented 1 year ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart: