search

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
615 stars 221 forks source link

decouple image name fetching from image puller #1263

Closed leoyifeng closed 1 year ago

leoyifeng commented 1 year ago
  1. decouple image name fetching from image puller to allow customization of fetching image names process
  2. change docker build to be multi arch compatible using apt-get install instead of curl amd64 tar
leoyifeng commented 1 year ago

@kevin-bates could you advise why the build failed ? thx

kevin-bates commented 1 year ago

Hi @leoyifeng - I just pushed a couple of updates to address the lint failures. However, after this, there's a lint failure on the pipx run interrogate -v step of make lint - which is failing. I'm not that familiar with that particular command, but it appears to look for documentation deficiencies. Not sure why it is complaining about the new file though.

kevin-bates commented 1 year ago

Hi @leoyifeng,

It looks like interrogate is complaining about missing docstrings on the fetch_image_names and the __init__ methods.

If you pip install interrogate then run interrogate -vv . (from the root of the repo), it will show the methods that are not "adequately" doc-stringed.

leoyifeng commented 1 year ago

@kevin-bates thx for the pointer, now all checks passed. appreciate it.

kevin-bates commented 1 year ago

Hi @leoyifeng - this is looking good. I think once the new kip variables are added to this table we should be good to go. Thanks.