search

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
623 stars 222 forks source link

upgrade the os version used by the kernel-image-puller from Debian 11 to Debian 12 #1363

Closed mmmommm closed 9 months ago

mmmommm commented 9 months ago

relate: https://github.com/jupyter-server/enterprise_gateway/issues/759

Problem

I am trying to pull from a private registry using the CRICTL_AUTH environment variable. However, this feature is only available in crictl (cri-tools) versions v1.24.0 and above. Currently, I am using v1.21.0 which is related to the OS version.

cri-tools v1.21.0 cri-tools v1.24.0

Proposed Solution

I propose two potential solutions:

If there are no major issues, it would be preferable to upgrade the OS version.

Additional context

I tried the method of mounting k8s secrets as suggested in this issue, but it did not work well with crictl.

I have applied a patch locally and it works fine. However, maintaining the patch is quite challenging, so I would like to incorporate this change.

https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_11/ https://download.opensuse.org/repositories/devel:/kubic:/libcontainers:/stable/Debian_12/

welcome[bot] commented 9 months ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

mmmommm commented 9 months ago

This issue is resolved by the following pr. https://github.com/jupyter-server/enterprise_gateway/pull/1364