jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
615 stars 220 forks source link

update crictl version from v1.21.0 to v1.24.0 #1364

Closed mmmommm closed 4 months ago

mmmommm commented 5 months ago

relate: https://github.com/jupyter-server/enterprise_gateway/issues/1363

This is Independently upgrade cri-tools to v1.24.0 or higher solution.

I am trying to pull from a private registry using the CRICTL_AUTH environment variable. However, this feature is only available in crictl (cri-tools) versions v1.24.0 and above. Currently, I am using v1.21.0 which is related to the OS version.

kevin-bates commented 5 months ago

Hi @mmmommm - thank you for the issue and subsequent pull request - I apologize for the lack of response.

Since we're talking only about the KIP image and assuming it would make on-going maintenance easier over installing an explicit version of crictl, I'd be in favor of moving to Debian 12 instead (as I believe you prefer). Would you mind pivoting to that approach?

mmmommm commented 4 months ago

@kevin-bates

Thank you for your response.

I'd be in favor of moving to Debian 12 instead

Of course, I agree with pivoting this pr to move to Debian 12 👍

mmmommm commented 4 months ago

It seems the operation is working without any issues.

$ cd ./etc/docker/kernel-image-puller
$ docker build  -t kernel-image-puller .
[+] Building 54.8s (25/25) FINISHED 
####################### Responses for command execution are being truncated.

$ docker run -d --name kip kernel-image-puller&& docker exec kip crictl -v
0d426a1de30e7cf6814f5266e23a88efc7132b7d5732cb0894c9592019be738a
crictl version v1.26.0
welcome[bot] commented 4 months ago

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

mmmommm commented 4 months ago

@kevin-bates I have a question, when do you think we will be able to use the fixed image?