Better handling of an empty container status in `confirm_remote_startup`

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.

https://jupyter-enterprise-gateway.readthedocs.io/en/latest/

Other

615 stars 220 forks source link

Better handling of an empty container status in `confirm_remote_startup` #1370

Open OrenZ1 opened 4 months ago

OrenZ1 commented 4 months ago

Modified confirm_remote_startup method to make handling of empty container status better, so that if a kernel pod dies while still in startup, the startup process will fail and the user won't have to wait for timeout.

welcome[bot] commented 4 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

OrenZ1 commented 4 months ago

Discussed in #1357

OrenZ1 commented 3 months ago

Hey! Is there any update on this PR?