search

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
619 stars 223 forks source link

Docker fixes #1372

Closed lresende closed 6 months ago

lresende commented 7 months ago

Docker fixes:

Fixes #1371

lresende commented 7 months ago

@kevin-bates any ideas on these build failures? do we need to update any of the jupyter infra for builds?

luong-komorebi commented 7 months ago

Based on the logs, there is a high chance that link-check fails because of this breaking change from pytest https://github.com/pytest-dev/pytest/issues/11779 on version 8.1, which I found that the job installed 445 The upstream package also did not lock the dependency so that pytest version should be <8.1

Therefore, from my view:

  1. In the short term, we can fix this by pre-installing pytest before this line is run https://github.com/jupyter-server/enterprise_gateway/blob/a1f9707163e9b10c04cd6e6dd50e439eab2a46bc/.github/workflows/build.yml#L74
  2. Long term, let's open a PR to the upstream to pin the version of pytest
lresende commented 6 months ago

Thank you @luong-komorebi , even though I had forced the pytest to be < 8.1 forcing install on the build file before link check seems to have resolved the issue.