need info on configuring the ssl at KIP Module

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.

https://jupyter-enterprise-gateway.readthedocs.io/en/latest/

Other

617 stars 223 forks source link

need info on configuring the ssl at KIP Module #772

Open suryag10 opened 4 years ago

suryag10 commented 4 years ago

hi, we had deployed the EG with SSL enabled. We would like to know how to configure the ssl at the KIP. Pls provide some pointers.

surya

kevin-bates commented 4 years ago

Hi @suryag10 - since KIP is cluster-internal, we haven't considered this to be a significant need. The KIP_GATEWAY_HOST env does specify the protocol and we use the requests package, but I suspect some additional effort would be necessary to implement its ability to interact with an ssl-enabled EG service.

suryag10 commented 4 years ago

Hi Kevin, Once the EG is SSL Enabled, client connecting to it, whether it may be a internal client or a external client, SSL should be enabled at CLient as well. I am ready with a PR for the SSL config params at KIP. Pls let me know.

kevin-bates commented 4 years ago

Excellent! Please go ahead and submit the PR and we'll get it reviewed.