search

jupyter-server / enterprise_gateway

A lightweight, multi-tenant, scalable and secure gateway that enables Jupyter Notebooks to share resources across distributed clusters such as Apache Spark, Kubernetes and others.
https://jupyter-enterprise-gateway.readthedocs.io/en/latest/
Other
621 stars 221 forks source link

There are some incorrect links in the DockerHub description. #968

Closed taeyeopkim1 closed 2 years ago

taeyeopkim1 commented 3 years ago

Description

Hello. In fact, this is what I found while looking for a solution to #962.

The link for "enterprise-gateway-swarm.sh" and "enterprise-gateway-docker.sh" in "https://hub.docker.com/r/elyra/enterprise-gateway/" seems to be connected incorrectly.

https://github.com/jupyter/enterprise_gateway/blob/master/etc/docker/enterprise-gateway-swarm.sh https://github.com/jupyter/enterprise_gateway/blob/master/etc/docker/enterprise-gateway-docker.sh

When I connect, I can see the NotFound page. I don't know where to ask, so I post this issue.

Screenshots / Logs

Environment

kevin-bates commented 3 years ago

What version of the docs are you looking at? I don't find these sections in any of the recent versions. That said, we do have outstanding references to enterprise-gateway-swarm.sh in kernel-docker.md and docker.md that should be appropriately replaced with docker-compose.yml.

taeyeopkim1 commented 3 years ago

Well.. What I found was just an overview. Would this screenshot help?

image

kevin-bates commented 3 years ago

Ah - of course - this is completely helpful - thank you. This file is located here: https://github.com/jupyter/enterprise_gateway/blob/master/etc/docker/enterprise-gateway/README.md, which we would then update on hub.

Given you've been exercising the docker deployments lately, are you interested in correcting these issues? (It would be greatly appreciated!)

taeyeopkim1 commented 3 years ago

I found the files in the link below.

https://github.com/jupyter/enterprise_gateway/blob/remove-python-2.x/etc/docker/enterprise-gateway-docker.sh https://github.com/jupyter/enterprise_gateway/blob/remove-python-2.x/etc/docker/enterprise-gateway-swarm.sh

Can I simply add those files in the "master" branch? I would like to provide a pull request, but if it is not what you intended, I will close the pull request.

kevin-bates commented 3 years ago

Hi @taeyeopkim1. The files you're trying to add are obsolete. Instead, we should update the instructions to deploy kernels in Docker and DockerSwarm to use the docker-compose.yml file and update the previously mentioned locations. Once the enterprise-gateway README.md is updated (along with the doc entries), we can update the docker hub entry with that content.

taeyeopkim1 commented 3 years ago

I understand what you mean. It will take some time. I will try but It is ok to proceed before me. Thank you.

kevin-bates commented 3 years ago

Thanks @taeyeopkim1 - your contribution will be appreciated.

bloomsa commented 2 years ago

Hi @kevin-bates, I can take this one. can you please assign this to me?

kevin-bates commented 2 years ago

Done. Thank you @bloomsa!

kevin-bates commented 2 years ago

Closing via #1049.