search

jupyter-server / jupyter_releaser

A set of helper scripts and GitHub Actions to aid in automated releases of Python and npm packages.
https://jupyter-releaser.readthedocs.io/en/latest/
Other
46 stars 64 forks source link

Tag format is hardcoded #535

Closed vidartf closed 10 months ago

vidartf commented 10 months ago

Problem

While that tag action does allow you to customize the tag format,

https://github.com/jupyter-server/jupyter_releaser/blob/811e16f4194b161331599582ecb30b3de659ac58/jupyter_releaser/cli.py#L514-L519

there are many places where the code hard-codes an assumption of v{version}:

https://github.com/jupyter-server/jupyter_releaser/blob/811e16f4194b161331599582ecb30b3de659ac58/jupyter_releaser/lib.py#L39-L43 https://github.com/jupyter-server/jupyter_releaser/blob/811e16f4194b161331599582ecb30b3de659ac58/jupyter_releaser/lib.py#L112-L114 https://github.com/jupyter-server/jupyter_releaser/blob/811e16f4194b161331599582ecb30b3de659ac58/jupyter_releaser/lib.py#L76-L78

Proposed Solution

Use the env var / cli arg for all relevant commands, and pass it through as needed.

welcome[bot] commented 10 months ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

vidartf commented 10 months ago

Closed in https://github.com/jupyter-server/jupyter_releaser/pull/536.