search

jupyter-server / jupyter_releaser

A set of helper scripts and GitHub Actions to aid in automated releases of Python and npm packages.
https://jupyter-releaser.readthedocs.io/en/latest/
Other
45 stars 64 forks source link

Add test for repository.url #539

Closed fcollonval closed 7 months ago

fcollonval commented 7 months ago

When publishing JupyterLab with the NPM provenance feature, it failed because the package.json file was not defining a proper repository.url. This adds a test for it in check-npm-dist

fcollonval commented 7 months ago

The first commit is expected to fail the test test_extract_dist_npm

jtpio commented 7 months ago

When publishing JupyterLab with the NPM provenance feature, it failed because the package.json file was not defining a proper repository.url

Linking to https://github.com/jupyterlab/jupyterlab/pull/15462 for reference.

blink1073 commented 7 months ago

Do you want me to wait for this PR before cutting a release next week?

fcollonval commented 7 months ago

Do you want me to wait for this PR before cutting a release next week?

I won't have much time in the coming week. Feel free to skip this one if it is not ready.

fcollonval commented 7 months ago

Thank you!

Thanks to you for finishing it up @blink1073