search

jupyter-server / jupyter_releaser

A set of helper scripts and GitHub Actions to aid in automated releases of Python and npm packages.
https://jupyter-releaser.readthedocs.io/en/latest/
Other
53 stars 66 forks source link

Emit a log line when Python publishing is skipped due to inconsistent package names #554

Closed mahendrapaipuri closed 9 months ago

mahendrapaipuri commented 9 months ago

Problem

When Python packages name differ in jupyter-releaser config and project's pyproject.toml, this check fails and publishing assets to PyPI will be skipped. Mostly it can happen due to inconsistent use of "hypens" and "underscores" in package names.

When this happens, jupyter-releaser will skip publishing without any warnings. It will emit the No files found but this is not entirely true as wheels and sdists files are present. This happend on the release of jupyterlab-topbar (see 113) and it was not immediately clear on why publishing has been skipped.

Proposed Solution

Emit a log line showing the differences in package names can be useful to debug the issue faster.

blink1073 commented 9 months ago

Thanks for the report @mahendrapaipuri, are you available to make a PR?

mahendrapaipuri commented 9 months ago

Sure @blink1073 , I can put up a PR!