Add ability to disable admin user check via flag

jupyter-server / jupyter_releaser

A set of helper scripts and GitHub Actions to aid in automated releases of Python and npm packages.

https://jupyter-releaser.readthedocs.io/en/latest/

Other

45 stars 64 forks source link

Add ability to disable admin user check via flag #559

Closed ElioDiNino closed 4 months ago

ElioDiNino commented 4 months ago

Added the flag logic into prepare_environment
Modified the applicable actions as a way of exposing this option to users (since it didn't seem applicable to add it to the CLI arguments)
Removed disallowed type input here

Happy to take feedback but I have tested using my changes on a private repo and things work as expected. I would appreciate a new tag being created once merged.

welcome[bot] commented 4 months ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

blink1073 commented 4 months ago

I'll make a release with this on Monday, thanks again!

welcome[bot] commented 4 months ago

Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart:

ElioDiNino commented 4 months ago

I'll make a release with this on Monday, thanks again!

Great to hear! No problem, glad to contribute 😃