search

jupyter-server / jupyter_releaser

A set of helper scripts and GitHub Actions to aid in automated releases of Python and npm packages.
https://jupyter-releaser.readthedocs.io/en/latest/
Other
45 stars 64 forks source link

Allow bump version to be run only once rather than per python-package #567

Open krassowski opened 2 months ago

krassowski commented 2 months ago

It would be really helpful if we could delegate version bumping to a singular script rather than have it invoked on per-python-package basis. This is especially true if both python packages and npm packages are in a monorepo.

Currently it runs in directory of each package:

https://github.com/jupyter-server/jupyter_releaser/blob/e727e2126a5f8d911d056e21bf64b6b610559493/jupyter_releaser/cli.py#L377-L383

Maybe we could have a new "single_version_bump" option?

krassowski commented 2 months ago

Both jupyter-collaboration and jupyter-chat would benefit from this.

krassowski commented 2 months ago

Because bump version also tries check if it can create tags for python packages (although these will never be created!), if these have the same version it will fail:

https://github.com/jupyter-server/jupyter_releaser/blob/897a828b4281d1eedc4f0b119bc452a948e38aff/jupyter_releaser/lib.py#L26-L46

Se we need to customize tag_format on per-package basis if there is more than one Python package (or allow to disable pushing tags for all but the top-level metapackage)