search

jupyter-server / jupyter_releaser

A set of helper scripts and GitHub Actions to aid in automated releases of Python and npm packages.
https://jupyter-releaser.readthedocs.io/en/latest/
Other
45 stars 64 forks source link

Normalise package name before comparison #568

Closed krassowski closed 2 months ago

krassowski commented 2 months ago

This should help with https://github.com/jupyterlab/jupyter-collaboration/issues/265#issuecomment-2058916408 - does it seem right? I always thought that dashes are preferred in package names over underscores and the https://packaging.python.org/en/latest/guides/writing-pyproject-toml/#name gives an example of spam-eggs

krassowski commented 2 months ago

I think this can get a bug label

krassowski commented 2 months ago

Note from jupyter-server meeting: we could use packaging.utils.canonicalize_name (thanks @bollwyvl)

krassowski commented 2 months ago

@blink1073 this should be ready for review