jupyter-server / jupyter_releaser

A set of helper scripts and GitHub Actions to aid in automated releases of Python and npm packages.
https://jupyter-releaser.readthedocs.io/en/latest/
Other
53 stars 66 forks source link

Releaser removes the `private` field in `package.json` file. #574

Closed trungleduc closed 1 month ago

trungleduc commented 6 months ago

Description

Reproduce

Release a jupyterlab extension with a private npm package.

Expected behavior

This field is not touched.

Context

Troubleshoot Output
Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.
Command Line Output
Paste the output from your command line running `jupyter lab` here, use `--debug` if possible.
Browser Output
Paste the output from your browser Javascript console here, if applicable.

welcome[bot] commented 6 months ago

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

jtpio commented 1 month ago

The commit created by the releaser removes my private field in the package.json file. For example this commit:

Could it be because this package.json had:

"private":"true",

instead of:

"private": true,

image

Note the second snippet passes true as a boolean, which should be the way for specifying a package is private.

Also the releaser handles private npm packages (which is often be the case in monorepos).

trungleduc commented 1 month ago

Nice catch, thanks @jtpio