search

jupyter-server / jupyter_releaser

A set of helper scripts and GitHub Actions to aid in automated releases of Python and npm packages.
https://jupyter-releaser.readthedocs.io/en/latest/
Other
45 stars 64 forks source link

Show the original error message from GitHub on Admin Check #579

Closed blink1073 closed 1 week ago

blink1073 commented 1 week ago

Description

The message for when the admin check fails makes some assumptions about the API response, but we should include the full API response to help debugging.

blink1073 commented 1 week ago

@ianthomas23, from what I can tell we are logging the full response, https://github.com/jupyter-server/jupyter_releaser/blob/2fc7de9eaad3c36905862ff37a28bf222fb2f254/jupyter_releaser/util.py#L610.

Can you post a link to your workflow run here?

ianthomas23 commented 1 week ago

@blink1073 https://github.com/ipython/ipykernel/actions/runs/9699310606/job/26767956167 is the latest run in which the Admin check failed.

blink1073 commented 1 week ago

Oh, right, that was before we backported the workflow changes. I realized what went wrong after that, we needed to set the branch field in the dialog. I opened #581 to properly handle the case where you run the workflow against a different branch.