Don't let ContentsHandler's internal 404 bubble up.

jupyter-server / jupyter_server

The backend—i.e. core services, APIs, and REST endpoints—to Jupyter web applications.

https://jupyter-server.readthedocs.io

BSD 3-Clause "New" or "Revised" License

484 stars 295 forks source link

Don't let ContentsHandler's internal 404 bubble up. #1328

Closed Carreau closed 10 months ago

Carreau commented 1 year ago

See https://github.com/jupyterlab/jupyterlab/issues/15153

ContentsHandler's get requests (and future HEAD requests https://github.com/jupyter-server/jupyter_server/issues/1327) should likely catch internal 404s and return a clean 404 with 'set_status()' and finish() this will avoid tornado to print tracebacks on non-existing files, which are often requested on purpose, like in SaveAs.

Zsailer commented 11 months ago

Yeah, I agree here, @Carreau. Thank you for raising here. I've labeled the issue with "good first issue" since this should be fairly strait forward.

bloomsa commented 10 months ago

can this be assigned to me? I'll give it a shot

bloomsa commented 10 months ago

FYI I think this can be closed now that #1357 is merged. let me know if I'm wrong

Carreau commented 10 months ago

Likely, let's close.