Path resolver API - Githubissues

jupyter-server / jupyter_server

The backend—i.e. core services, APIs, and REST endpoints—to Jupyter web applications.

https://jupyter-server.readthedocs.io

BSD 3-Clause "New" or "Revised" License

484 stars 295 forks source link

Path resolver API #1331

Open krassowski opened 1 year ago

krassowski commented 1 year ago

This patch demonstrates the scaffold of the new path resolver API endpoint proposed in #1280.

This depends on a sibling PR https://github.com/jupyter/jupyter_client/pull/1005

Questions:

should I use self.kernel_manager or self.multi_kernel_manager? (these are not well documented in code)

In future we could include an entry point (e.g. traitlet) to define additional scopes (e.g. from remote file systems), but this is out of scope for this PR which focuses on distinguishing between a path from kernel and server.

krassowski commented 8 months ago

@meeseeksdev tag enhancement

lumberbot-app[bot] commented 8 months ago

Awww, sorry krassowski you do not seem to be allowed to do that, please ask a repository maintainer.

krassowski commented 7 months ago

Can a repository maintainer add labels to my pull requests or configure lumberbot to make it usable? It helps to see what is the CI status and reduces number of distracting spam emails about failure status.

blink1073 commented 7 months ago

I'm afk for the next few days but would merge such a PR. 😃

krassowski commented 6 months ago

Marking this as ready-for review because:

https://github.com/jupyter/jupyter_client/pull/1005 is ready,
I did not get much feedback on https://github.com/jupyter/jupyter_client/issues/1006 so I assume this is not something folks would have capacity to review right now (and that appears to be a rather large feature which would benefit some upfront planning).

However, if the decision is to go with https://github.com/jupyter/jupyter_client/issues/1006 and close this PR (along with https://github.com/jupyter/jupyter_client/pull/1005) I would totally understand this.

krassowski commented 5 months ago

Another use case for this API is https://github.com/jupyterlab/jupyterlab/issues/16235 - we currently cannot reliably reconcile the files returned by the debugger with the file system.