Closed jayeshsingh9767 closed 1 year ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Thanks @jayeshsingh9767! It looks like we could put the debug log in the _get_os_path
and handle all of the cases you added.
@blink1073 Thanks for the Quick Review, initially I too thought so but I was not sure if self.log object is available inside fileio.py will try out logging inside _get_os_path
and check if all Testcases pass.
The typing failures are unrelated, I'll handle those in a follow up PR.
Oh actually, the lint is related, ha! I'll push the updates.
Thanks @blink1073
Congrats on your first merged pull request in this project! :tada: Thank you for contributing, we are very proud of you! :heart:
Congrats on closing a 7 years old issue ! 🥳
closes issue jupyter/notebook#857
Changes made: added self.log.debug("Reading path from disk: %s", path) in filemanager.py in jupyter_server